4 ms·
This is where mandatory code reviews really help. He can't merge that crap and mess everyone else up without someone approving the changes. Also, to be frank,
by jacobsenscott 7y ago
This is where mandatory code reviews really help. He can't merge that crap and mess everyone else up without someone approving the changes.
Also, to be frank, if his code is reverberating all over the code base like that, causing merge conflicts and re-write all over the place, he is a terrible engineer - not a brilliant engineer. He clearly had no knowledge of the basic SOLID principles, modularization, encapsulation, etc. He was a rookie blasting experiments all over the code base.
- spease 7y agoWell, or the code base had no organization to begin with and he’s moving in that direction. Sometimes individual people can be very focused on their particular assignment and greatly resent somebody forcing them to make even small changes. Even if those are to make a global API smaller and more consistent.