4 ms·
My best code review experiences, bar none, were at a company that did all code reviews side-by-side at our desks. This was before the days of online code review
by reggieband 7y ago
My best code review experiences, bar none, were at a company that did all code reviews side-by-side at our desks. This was before the days of online code review tools like those built into github - you physically pulled your chair next to the submitters desk and went through the review face-to-face while they showed the diff on their screen.
There were times this was cumbersome and intrusive. I tend to make many small changes and I remember a few of my co-workers being frustrated at the frequency I asked for reviews. I remember myself feeling frustrated by the interruption to my "code flow" on occasions. But the benefit of the conversation that happened in those reviews far outweighs any negative I remember.
Now that people are socialized to the asynchronous online review process I don't think I can imagine people going back to this synchronous and time consuming process.