3 ms·
Ultimately, any rules you create tend to break down, as there is always an edge case personality that will dislike the way you worded something. The best advic
by softfalcon 7y ago
Ultimately, any rules you create tend to break down, as there is always an edge case personality that will dislike the way you worded something.
The best advice I have seen applies to regular conversation as well as code reviews:
When you see something that is confusing, incorrect, or debatable, take a stance of genuinely attempting to understand the other person's mindset before offering feedback.
--
For example, asking questions in a respectful manner such as:
"Would you mind elaborating on why you chose this pattern of implementation?"
Will result in a positive conversation while also having them document in the review their mindset for posterity and further clarity of discussion.
--
From there, constructive conversation and asking if they're interested in feedback/alternative approaches can happen.
This way you maintain respect and show an honest attempt to understand others with every comment and suggestion you make to a PR.
--
tldr; ask questions to gain perspective before you start dictating to others how things should be done.