2 ms·
I disagree. Your comment suggest that it's obvious to write this way, while I would argue, if it would be obvious for everyone, you wouldn't even need to write
by rmetzler 7y ago
I disagree. Your comment suggest that it's obvious to write this way, while I would argue, if it would be obvious for everyone, you wouldn't even need to write these down.
Also it implies, that it's obvious, and if I didn't knew these rules exist I'm not a professional and may be a cause of a culture problem.
The thing is, most of the examples aren't really rude, they just communicate that the one who wrote the code is doing something wrong, while the reason you do code reviews is to improve the code.
But it's not easy to communicate without hurting peoples feelings even when you didn't mean to. Even between cultures there is a lot of difference in how direct you should be and what is considered rude.