4 ms·
I find really hard about code reviews is how people have different styles. Some people writing more procedural, some more functional, some want to use Actor mod
by rb808 7y ago
I find really hard about code reviews is how people have different styles. Some people writing more procedural, some more functional, some want to use Actor model, others like layers, others like having loads of dependencies injected. What are you supposed to do? Haven't even started on the plethora of libraries and frameworks.
- netule 7y agoStick to whatever conventions already exist in the project for consistency.
- ken 7y agoI can count on the fingers of one hand the number of programs I've seen in my life longer than 100 lines with consistent conventions.
- kradroy 7y agoLearn to be flexible. I've been writing and reading code for 30 years. You'll fight a losing battle if you try to enforce much more than "code must pass tests and work in production."
- jacobsenscott 7y agoThird party dependencies are generally toxic to the long term health of your application. So I push back hard against adding new frameworks or libraries unless they really carry their weight. But if someone wants to use a new language feature we don't use often, or try out a new pattern I try and give it a chance. If you shut down everything you're not giving your people room to grow their skills, and they'll move on.
- xsmasher 7y agoThe style isn't as important unless it impacts the reviewer's ability to read and understand the code, or the maintainability of the code.