3 ms·
Practices like this are ridiculous. Of course you should be respectful in a code review, but you should also be to the point and ask questions if you don't unde
by nbar1 7y ago
Practices like this are ridiculous. Of course you should be respectful in a code review, but you should also be to the point and ask questions if you don't understand why they did something they did, even if there is a "better" way you know of. That's how people learn.
The examples they give are just bad.
- pytester 7y ago>Of course you should be respectful in a code review It seems self evident but there are a lot of people who don't believe this and take a kind of perverse pride in "tearing others' code to shreds" so it's worth enshrining in policy if nothing else.
- tstrass 7y agoI agree the examples are bad. An article like this would be really helpful with more and better examples.
- svaha1728 7y agoWorking in various companies I have seen code reviews become filled with micro-aggressions and outright nastiness. Code reviews have a purpose but that often gets clouded in personal judgements. This ends up making things like refactoring difficult, as people just don’t want to bother with the process.
- Japhy_Ryder 7y agoI agree. Really poorly done - I'm surprised this is on the front page of HN.
- DoofusOfDeath 7y agoPerhaps, but I'm finding that the resulting discussion surfaces a lot of wisdom, good ideas, and different perspectives.
- jrochkind1 7y agoWhat do you think are bad about the examples? They all seem reasonable to me.