3 ms·
>Split your code submission using pull requests and give the team an opportunity to review the PRs > Not communicating. Candidates who submitted all the code t
by sandGorgon 7y ago
>Split your code submission using pull requests and give the team an opportunity to review the PRs
> Not communicating. Candidates who submitted all the code to master branch, which does not give us the ability to provide feedback on the various implementation phases. Because we are a distributed team, structured communication is critical to us.
how do you ask your candidate to split your answer using PR ? We would like this during interviewing but it ends up being a single PR. I dont want to impose create separate branches and a PR for each small incremental feature thing.
I'm assuming you are using Github
- alexk 7y agoGood question! We usually recommend to submit a fully complete logical part, e.g. auth middleware, client, server. We recommend against submitting incomplete functionality in a PR because it is hard for our interview team to understand whether it's incomplete or complete and has defects.
- sandGorgon 7y agoso would each complete logical part be a separate branch with its PR ? and then branch from the previous branch to create the next PR? I'm just wondering if you found there to be any cognitive overhead here.