3 ms·
The mistake he made is not specifically a "crypto code" problem, it was merely forgetting to increment the new variable It wasn't even that. My mistake was re
by cperciva 16y ago
The mistake he made is not specifically a "crypto code" problem, it was merely forgetting to increment the new variable
It wasn't even that. My mistake was refactoring code incorrectly. The increment was there for two years until it got lost in the refactoring.
The great thing about widely used open-source utilities is the extensive vetting they receive
Wearing my FreeBSD Security Officer hat: It's nice to think that, but most open source code gets a shockingly small amount of auditing.
- tptacek 16y agoThis is a head-explodey subthread. Sure, Colin, O.K., it wasn't a "crypto mistake", it was a "refactoring mistake that happened to basically turn off your crypto". The fact that perfectly innocent and benign seeming refactoring changes can do that to crypto is exactly why generalist developers should not be writing crypto code.
- cperciva 16y agoI've seen major security vulnerabilities result from losing a single '=' (turning "if (uid == 0)" into "if (uid = 0)") or adding a single '=' (turning "for (...; i < N; ...)" into "for (...; i <= N; ...)"). That's half the typo size of a missing '++'. Sure, writing crypto code is dangerous. And writing user-authentication code is dangerous. But are you seriously going to say that writing loops is dangerous and generalist developers shouldn't do it? If the underhanded C contest taught us anything, it's that perfectly innocent and benign seeming changes can introduce security vulnerabilities anywhere.
- cookiecaper 16y agoAre we to understand that "crypto developers" never forget to increment something or never have copy-paste errors? It seems most of the difference between a "generalist developer" and a "crypto developer" is the amount of money his employer puts into QA.