4 ms·
Google's engineering practice documentation has a section on 'The Standard of Code Review': https://google.github.io/eng-practices/review/reviewer/standard.html
by jamessb 7y ago
Google's engineering practice documentation has a section on 'The Standard of Code Review': https://google.github.io/eng-practices/review/reviewer/standard.html https://google.github.io/eng-practices/review/reviewer/stand...
It includes this important rule:
> In general, reviewers should favor approving a CL [changelist - equivalent to a patch] once it is in a state where it definitely improves the overall code health of the system being worked on, even if the CL isn’t perfect.
- 3minus1 7y agoI'm really glad this was posted. The rule that makes sense to me, when before I didn't know where to draw the line between accept and nitpick. Gonna start thinking about this in code reviews going forward.