5 ms·

Calling the codebase a nightmare is the understatement of the year. I tried forking it at some point. I don't think I could reasonably even attempt describe the

Calling the codebase a nightmare is the understatement of the year. I tried forking it at some point. I don't think I could reasonably even attempt describe the codebase in a way that wouldn't get me banned from HN, and most likely the rest of the internet. Needless to say I gave up.

Hendrikto 7y ago
That makes me very curious. Could you write a blogpost on the topic by any chance?
echelon 7y ago
We would actually love to read that. An article title such as "Popular open source software Calibre has a codebase that isn't just bad, it's outright dangerous" would definitely make me click. If you feel strongly, please do this. It adds value. The creator might really benefit from it.
- 6gvONxR4sf7o 7y ago
  How would you feel if someone came out with an article about "echelon's code isn't just bad, it's outright dangerous" and wrote a whole article attacking and shaming you, just because you might benefit from it? Sure you might benefit, but there are much more constructive, kinder ways to do it. Even if he and his code aren't great, Goyal's done a lot of free public service here. Let's not be dicks. If you want to learn about the codebase, here it is https://github.com/kovidgoyal/calibre https://github.com/kovidgoyal/calibre
  - echelon 7y ago
    Good point. I was responding to the tone of the OP, but it's not at all kind or constructive. They should be praised for their contributions, not torn down. That would be a dick move. Forgive me, I have the flu and I'm grumpy today.
- saagarjha 7y ago
  That’s clickbait and not very constructive. Fun to read, maybe, but it probably won’t be for Kovid and it won’t help make Calibre better.
- justin66 7y ago
  > If you feel strongly, please do this. It adds value. The creator might really benefit from it. There is an awful lot of self-deception packed into this paragraph. > We would actually love to read that. That part is probably true for many.
- CodeMage 7y ago
  No. I definitely wouldn't like to read a post with an attitude like the one espoused in the titled you proposed. However, I would gladly read a post that reviews Calibre codebase in a helpful, friendly way.

Hendrikto 7y ago

That makes me very curious. Could you write a blogpost on the topic by any chance?

echelon 7y ago

We would actually love to read that. An article title such as "Popular open source software Calibre has a codebase that isn't just bad, it's outright dangerous" would definitely make me click. If you feel strongly, please do this. It adds value. The creator might really benefit from it.

6gvONxR4sf7o 7y ago
How would you feel if someone came out with an article about "echelon's code isn't just bad, it's outright dangerous" and wrote a whole article attacking and shaming you, just because you might benefit from it? Sure you might benefit, but there are much more constructive, kinder ways to do it. Even if he and his code aren't great, Goyal's done a lot of free public service here. Let's not be dicks. If you want to learn about the codebase, here it is https://github.com/kovidgoyal/calibre https://github.com/kovidgoyal/calibre
- echelon 7y ago
  Good point. I was responding to the tone of the OP, but it's not at all kind or constructive. They should be praised for their contributions, not torn down. That would be a dick move. Forgive me, I have the flu and I'm grumpy today.
saagarjha 7y ago
That’s clickbait and not very constructive. Fun to read, maybe, but it probably won’t be for Kovid and it won’t help make Calibre better.
justin66 7y ago
> If you feel strongly, please do this. It adds value. The creator might really benefit from it. There is an awful lot of self-deception packed into this paragraph. > We would actually love to read that. That part is probably true for many.
CodeMage 7y ago
No. I definitely wouldn't like to read a post with an attitude like the one espoused in the titled you proposed. However, I would gladly read a post that reviews Calibre codebase in a helpful, friendly way.