3 ms·
Interesting. In my experience, the feedback (1) introduces me to new concepts or utilities I had not considered using -- may or may not incorporate (2) shows
by Xurinos 16y ago
Interesting. In my experience, the feedback
(1) introduces me to new concepts or utilities I had not considered using -- may or may not incorporate
(2) shows me what patterns other developers are accustomed to seeing -- if I chose a pattern for subjective reasons and I am outnumbered, incorporate and adapt
(3) sometimes uncovers bugs or places where I am not fitting into the architecture well enough (or someone else's new development) -- extra eyes, extra attention, all nice
(4) allows me to turn around and show my "reviewers" approaches in #1 and #2 -- educates and changes local culture
(5) introduces other developers to parts of the code they did not write
In short, the code review is not just about me. Although your two code reviews may give me red marks going back and forth, it is ultimately up to me to decide which way to go, and I may benefit from seeing both sides if I have not already seen those. There is a pretty small percentage that I would say is actually completely useless to me. I suppose it depends on how one conducts reviews, and it may also depend on whether your project source is shared with and maintained by others.
- JoeAltmaier 16y agoWhen coding fast, nobody knows your code like you do. Reviews are then either a) too late to do any good, or b) shallow. Both are nearly useless. If you have a mentor and are new, then the mentor's review can help. But in that case, the mentor probably could have written your code faster than you did. The review may be useful to you, but the project would have in fact gone faster had you not been there. If you code fast, outrun the others around you, are any good at all, then code review is at best annoying.