3 ms·
Using size_t as the common solution seems like the way to go. struct string { char *data; size_t size; size_t alloc_size; }; struct string_view { char
by kzrdude 7y ago
Using size_t as the common solution seems like the way to go.
struct string { char *data; size_t size; size_t alloc_size; };
struct string_view { char *data; size_t size; };
And we have the same design that C++ uses.
- billziss 7y agoI do not think I have ever seen a string that needs more than 64K, but then again I do not read whole files in memory in C. (I do in Python.) So this would be wasteful in many cases. My personal variant uses 32-bits for length and 32-bits for refcount, which aligns well on most platforms, including 64-bit ones. Something like: struct string_header { int32_t refcnt; int32_t length; // character content starts here }; Given a char pointer to get to the header you must do: ((struct string_header *)p)[-1]
- saagarjha 7y agoHow would you use the refcount?
- billziss 7y agoI use the refcount to avoid copying the string when passing it around. I just refcount it instead. To clarify this is part of a larger library that includes other memory management machinery, such as autorelease pools, etc.
- papermachete 7y ago>I >I >I There is no 'I' in standard libraries :)
- nneonneo 7y agoC++ implementations sometimes optimize for storing short strings inside the string structure itself. One approach looks something like this on 64-bit machines: struct string { union { struct { char *ptr; size_t capacity; }; char str[16]; } data; size_t length; }; It looks complex, but it’s actually a really nice design because it requires no separate allocation for strings less than 16 bytes long, which is a common case, and the strings are relatively compact. And, it stores a capacity parameter which allows you to know when it’s safe to grow the string without allocating, making it possible to implement efficient repeated concatenation.