3 ms·
I use the comment test. It's pass/fail and goes like this: "Suppose I'm reading some code and I see an obvious typo in a comment. What's the process for fixing
by quotemstr 7y ago
I use the comment test. It's pass/fail and goes like this: "Suppose I'm reading some code and I see an obvious typo in a comment. What's the process for fixing it?"
(Note: I've actually gotten all of these answers, albeit sometimes only after I joined a group (prompting me to develop this test in the first place)).
Fail: "just edit the file lol"
Pass: "edit the file and check it in"
Pass: "edit the file, send a diff, get a +1, and check it in"
Suspicious: "edit the file, send a diff, get your code and style approvers, wait for presubmit, and check it in"
Hard fail: "file a bug..."
WTF are you even doing: "we can focus on code quality issues after this milestone"
- protomyth 7y agoRemember to ask about 'code lockdowns', some coding jobs have seasons of a sort.