3 ms·
> We thought about running it automatically on every test build and/or collecting types from a small fraction of live network requests, but decided against it a
by j88439h84 7y ago
> We thought about running it automatically on every test build and/or collecting types from a small fraction of live network requests, but decided against it as either approach is too risky.
I wonder what's too risky about it? Did you try it and something broke? Instagram's MonkeyType seems to think it works ok in production. https://monkeytype.readthedocs.io/en/stable/stores.html https://monkeytype.readthedocs.io/en/stable/stores.html
- boulos 7y agoTreating “all the types we happened to see at runtime” as “all the types allowed” automatically is I think what they meant as “risky”. MonkeyType seems to record the answers and then let you decide (via apply) if you want to agree. I’m a little surprised more people didn’t use this approach, but it probably makes for fairly clumsy type sets that the human is better off saying “Eh, I’ll just document it correctly”.