4 ms·
I did a pretty reasonable chunk of C++ code once years ago. I was junior level. Wanted a good review. I got 21 comments to remove blank lines and none about th
by patthebunny 7y ago
I did a pretty reasonable chunk of C++ code once years ago. I was junior level. Wanted a good review.
I got 21 comments to remove blank lines and none about the code. Thanks. Really useful. This was the team of "experts" on the code base.
Then a principle engineer reviewed some other code and oh look, actual useful comments.
Nitpicking can be worse than useless. Obfuscates or ignore real issues in the code. Seems to usually be a sypmtom of the reviewing not being competent enough to actually review the code properly.
- mytailorisrich 7y agoSometimes people don't want to actually review but feel they have to leave comments. Trivial comments are a sign of that.