3 ms·
I agree, my role of thumb is to only review code if I was asked by the author to do so, and never offer to review someone's else code. Code is a bit like music
by meitham 7y ago
I agree, my role of thumb is to only review code if I was asked by the author to do so, and never offer to review someone's else code.
Code is a bit like music, there is very little right or wrong, but a lot of flavours and opinions.
- mxz3000 7y agoSure when you're the only one working on a project. Otherwise, the only right way of writing code is that agreed upon by the whole team. Any personal opinion, while affecting the 'opinion' of the team, does not matter.
- Traubenfuchs 7y agoVery little wrong? You haven't seen enough code! I have seen everything in merge requests: From liquibase scripts that would have wiped the production database to production secrets in yml files.