3 ms·
That advice is what I try to do more. I think people who veer more into the logic/engineering side of it forget some obvious emotional common sense: > If you s
by Iv 7y ago
That advice is what I try to do more. I think people who veer more into the logic/engineering side of it forget some obvious emotional common sense:
> If you see something nice in the CL, tell the developer, especially when they addressed one of your comments in a great way. Code reviews often just focus on mistakes, but they should offer encouragement and appreciation for good practices, as well. It’s sometimes even more valuable, in terms of mentoring, to tell a developer what they did right than to tell them what they did wrong.