2 ms·
>It's very interesting that so much of it is about the social aspects of engineering Code reviews are mostly in the social domain and not the technical domain.
by BeetleB 7y ago
>It's very interesting that so much of it is about the social aspects of engineering
Code reviews are mostly in the social domain and not the technical domain. Other than bugs and performance[1], everything in a typical code review is an opinion. Hence, you need guidelines on how to handle differences in opinions. Different work environments structure code reviews differently, but often the worst is where a reviewer finds problems, and the code review cannot be marked complete until the reviewer is satisfied. This often leads to "I have to change my code to the reviewer's preferred style" instead of "The reviewer found real issues". Other models, exist and are better.
[1] Actually, performance conversations are very often based on opinions. Things like what level of performance is acceptable, etc.