4 ms·

They didn't give the two examples that are most common inside Google: Google I/O is coming up, or annual performance reviews are coming up. Strangely they also

by bt848 7y ago

They didn't give the two examples that are most common inside Google: Google I/O is coming up, or annual performance reviews are coming up. Strangely they also list as "not an emergency" rollbacks of clearly broken code, but that's an exception to review rules inside Google. Anyone can do a pure rollback of a change without getting the approval of the owners of the code, and there are automated tools that will roll back changes that appear to have broken at least 1000 tests, without human review. Edit: There's even a button right in the code review web UI to roll back a committed change.

NoodleIncident 7y ago
> Google I/O is coming up, or annual performance reviews are coming up. As long as everyone admits it, sounds like those are actual emergencies :)
cameronbrown 7y ago
> at least 1000 tests The threshold for this seems at least a little too high, doesn't it?
- bt848 7y ago
  They have a lot of tests :-) Abseil-cpp alone has 2400 tests, at least in the open-source tree. https://github.com/abseil/abseil-cpp/tree/master/absl/base https://github.com/abseil/abseil-cpp/tree/master/absl/base
- sanderjd 7y ago
  I was thinking low :)