5 ms·

Found a C "goto" in that code, too - eek. Maybe there was a good reason...

• Narishma 7y ago
  There's nothing wrong with goto in C.
  • presidentscroob 7y ago
    It's a good pattern to DRY-up resource-releasing unwind code. In an ideal world, there would be closures, RAII and fluent interfaces (macros) that would wrap allocation, deallocation, error and success handling without needing C++ and avoiding resource leaks. int some_func(void) { int result = ERR; HANDLE foo = alloc_foo(); if (!foo) goto err0; HANDLE bar = alloc_bar(); if (!bar) goto err1; if (do_something_else() < 0) goto err2; result = OK; err2: release_bar(bar); err1 release_foo(foo); err0: return result; }
  • yitchelle 7y ago
    As with everything in C, it must be used with care and thought. It can come back and bite you in the future if use frivolously.
• ben_bai 7y ago
  Nothing wrong with using goto, sparingly. It's the preferred way for error handling in C. Nobody has code like this anymore 10 I=1 20 PRINT "HELLO " 40 PRINT %I 50 IF (%I > 3) 10 40 30 PRINTLN "WORLD" 45 PRINTLN 42 I=%I+1 Notice no goto statement, yet lots of implicit gotos.
  • cjarrett 7y ago
    What about a Goto within a switch statement that's within another switch statement in a function that's 3000 lines long?