2 ms·
I think it goes both ways. In every shop I work at, I do ask WHY someone refactored something I have done. However, I do not do so with any malice. As you poi
by to11mtm 7y ago
I think it goes both ways.
In every shop I work at, I do ask WHY someone refactored something I have done. However, I do not do so with any malice.
As you point out above, sometimes, that first writeup is a working implementation, and while important, the first iteration is often not optimal.
Thus, asking why is useful because it helps us become better developers. Talking about the changes helps share knowledge, and, yes, when questionable changes are made, it can be a lesson for the refactor-er as well.
And when I am the refactor-er... I will try to explain my changes in the PR. Usually with a polite explanation of why I refactored.