3 ms·
Ha, omg this is impossible to read. Using async/await here would go a long way to helping. But honestly this just seems like a work in progress, so code cleanl
by wesleytodd 7y ago
Ha, omg this is impossible to read. Using async/await here would go a long way to helping. But honestly this just seems like a work in progress, so code cleanliness and ability for others to read and contribute might not be the focus.
Also, generally people do not put all their logic in the same file , in express apps. Just breaking out the business logic from the express app setup would also help to make it more readable/understandable.
- buu700 7y agoIt's also incorrect usage of promises; idiomatically no part of that code should be nested more than two levels deep. But yeah, async/await would be both cleaner to read and easier to write correctly. (Ultimately a minor issue at this stage of what's otherwise a really neat project!)
- tdjsnelling 7y agoAppreciate all the feedback, the code is certainly pretty hacky right now and I intend to clean it up in future. Glad you like the project!
- dang 7y ago> Ha, omg this is impossible to read Please edit swipes like this out of your HN comments, particularly in Show HN threads: https://news.ycombinator.com/showhn.html https://news.ycombinator.com/showhn.html.