4 ms·
The core of the product is a bunch of regex or something smarter? Odd that a product that want you to base your legal safety is not more transparent about the
by gcbw3 7y ago
The core of the product is a bunch of regex or something smarter?
Odd that a product that want you to base your legal safety is not more transparent about the actual implementation on the initial page, instead it reads like an advertisement for closed source SaaS.
- gcbw3 7y agoanswering myself, yes. It is a pile of regex https://github.com/microsoft/presidio/blob/master/presidio-analyzer/analyzer/predefined_recognizers/credit_card_recognizer.py https://github.com/microsoft/presidio/blob/master/presidio-a... and i can't find the body of test data easily... that's not good.
- m00x 7y agoThey also have a NLP engine, the regexes are just predefined recognizers for known formats. https://github.com/microsoft/presidio/tree/master/presidio-analyzer/analyzer/nlp_engine https://github.com/microsoft/presidio/tree/master/presidio-a...
- bpchaps 7y agoSerious question - is there anything fundamentally wrong with using regex here?
- jasonshaev 7y agoFor the specific example cited (credit card numbers) the Luhn check is very standard. So, no there isn't :)
- gcbw3 7y agoSo you might have more fun with this email one https://github.com/microsoft/presidio/blob/master/presidio-analyzer/analyzer/predefined_recognizers/email_recognizer.py https://github.com/microsoft/presidio/blob/master/presidio-a... :) ... seriously, they should have broken that down, or used the multi-line with comments pattern, if they really want people to contribute to this.
- bpchaps 7y agoYeah, seriously. Are email addresses even regular to the extent that a regex would work 100% of the time?