3 ms·
The way I see the list is that it isn't meant to be exhaustive, it's meant to be functions that contributors are likely to try to use. A new contributor might
by LukeShu 7y ago
The way I see the list is that it isn't meant to be exhaustive, it's meant to be functions that contributors are likely to try to use. A new contributor might not realize that they should be using Git's internal strbuf.h instead of the libc string functions. It's a way to give them feedback on that from their compiler, before they spend more time on the patch and send it to the mailing list.
- rkagerer 7y agoMight be nice if the error messages suggested such alternatives instead of just saying "banned"?
- grogenaut 7y agoI believe the git project welcomes suggestions and discussion via the mailing list, and also accepts patches that like you suggested above.
- masklinn 7y agoAlso seems mostly for functions which look innocent and are likely to be used but are very easy to misuse. setjmp/longjmp is not in this category, it might be argued to be easy to misuse but doesn't look innocent and is not likely to be used in normal codebases.