4 ms·

Looks like the second vsprintf definition should be "BANNED(vsprintf)", not "BANNED(sprintf)". Not that it matters much, as it only affects the error message.

by jcl 7y ago

gus_massa 7y ago
Nice catch! You can send a "PR", but note that they have their own custom "PR" procedure, not the standard "PR" procedure in GitHub. > Git Source Code Mirror - This is a publish-only repository and all pull requests are ignored. Please follow https://github.com/git/git/blob/master/Documentation/SubmittingPatches https://github.com/git/git/blob/master/Documentation/Submitt... procedure for any of your improvements.
- LukeShu 7y ago
  Their "custom" procedure is the `git send-email` command, which has a lot more of a claim to be "standard" than GitHub's custom procedure.
- saagarjha 7y ago
  Aside: GitHub’s refusal to provide a feature to close pull requests for mirrors is utterly ridiculous since it requires that people (or bots) go around and disable pull requests and point people to the patch submission process.
  - OJFord 7y ago
    What's weirdest to me is that it differs from the policy on Issues, which can be turned off in settings. I sort of get not allowing it, except that it's inconsistent.
- yjftsjthsd-h 7y ago
  > not the standard "PR" procedure in GitHub If it is specific to one implementation, then it is not standard, pretty much by definition.
  - notatoad 7y ago
    the word "standard" has more than one meaning. it's not standard by the definition of standard that you chose, but you can use your context cues to realize that it's not the definition of standard that OP meant.
zeckalpha 7y ago
I’m sure they’d welcome a patch.
peff 7y ago
Yes, you're right. Patches welcome. We do our development on a mailing list; see https://git-scm.com/docs/SubmittingPatches https://git-scm.com/docs/SubmittingPatches for details. However, if you're more comfortable using GitHub PRs, there's a gateway interface at https://gitgitgadget.github.io/ https://gitgitgadget.github.io/.
- ttaylorr 7y ago
  I submitted a patch to fix this typo from my fork (which you can see at https://public-inbox.org/git/cab687db8315dd4245e1703402a8c76218ee1115.1566762128.git.me@ttaylorr.com/T/#u https://public-inbox.org/git/cab687db8315dd4245e1703402a8c76...).

Looks like the second vsprintf definition should be "BANNED(vsprintf)", not "BANNED(sprintf)". Not that it matters much, as it only affects the error message.

by jcl 7y ago

Looks like the second vsprintf definition should be "BANNED(vsprintf)", not "BANNED(sprintf)". Not that it matters much, as it only affects the error message.

gus_massa 7y ago

Nice catch! You can send a "PR", but note that they have their own custom "PR" procedure, not the standard "PR" procedure in GitHub. > Git Source Code Mirror - This is a publish-only repository and all pull requests are ignored. Please follow https://github.com/git/git/blob/master/Documentation/SubmittingPatches https://github.com/git/git/blob/master/Documentation/Submitt... procedure for any of your improvements.

LukeShu 7y ago
Their "custom" procedure is the `git send-email` command, which has a lot more of a claim to be "standard" than GitHub's custom procedure.
saagarjha 7y ago
Aside: GitHub’s refusal to provide a feature to close pull requests for mirrors is utterly ridiculous since it requires that people (or bots) go around and disable pull requests and point people to the patch submission process.
- OJFord 7y ago
  What's weirdest to me is that it differs from the policy on Issues, which can be turned off in settings. I sort of get not allowing it, except that it's inconsistent.
yjftsjthsd-h 7y ago
> not the standard "PR" procedure in GitHub If it is specific to one implementation, then it is not standard, pretty much by definition.
- notatoad 7y ago
  the word "standard" has more than one meaning. it's not standard by the definition of standard that you chose, but you can use your context cues to realize that it's not the definition of standard that OP meant.

zeckalpha 7y ago

I’m sure they’d welcome a patch.

peff 7y ago

Yes, you're right. Patches welcome. We do our development on a mailing list; see https://git-scm.com/docs/SubmittingPatches https://git-scm.com/docs/SubmittingPatches for details. However, if you're more comfortable using GitHub PRs, there's a gateway interface at https://gitgitgadget.github.io/ https://gitgitgadget.github.io/.

ttaylorr 7y ago
I submitted a patch to fix this typo from my fork (which you can see at https://public-inbox.org/git/cab687db8315dd4245e1703402a8c76218ee1115.1566762128.git.me@ttaylorr.com/T/#u https://public-inbox.org/git/cab687db8315dd4245e1703402a8c76...).