5 ms·
I am a bit disappointed- I skipped the details and now that I've tried it hands-on I see that it is hardcoding the link to the repo in the button's HTML. So eve
by leetrout 7y ago
I am a bit disappointed- I skipped the details and now that I've tried it hands-on I see that it is hardcoding the link to the repo in the button's HTML. So even after you fork it the button still point's to Google's repo.
That makes sense, of course, but if that step were gone (maybe by checking referrer?) it would be a lot slicker!
- alpb 7y agoDisclaimer: co-author of the project. It's already on our list: https://github.com/GoogleCloudPlatform/cloud-run-button/issues/16 https://github.com/GoogleCloudPlatform/cloud-run-button/issu... Ideally you'd just link to a URL like deploy.cloud.run and we'll figure out the rest from Referer.
- leetrout 7y agoAwesome! Thanks for the quick response on that!
- deleted 7y ago[deleted]