4 ms·
Great work, I like the simplicity! So far I have two issues with your solution: 1. It doesn't accept my email address. Looks like the pattern is way too stric
by dalbotex 7y ago
Great work, I like the simplicity!
So far I have two issues with your solution:
1. It doesn't accept my email address. Looks like the pattern is way too strict and doesn't allow any new TLDs.
2. The use-case I most often see Splitwise used for is trips abroad with friends. In this situation, expenses are often recorded while no internet connection is available and synced later. I'm not sure if IOU supports this, I haven't tried it.
- janberchtold 7y agoThanks! 1. Can you send an email to iou@iou.ch so I can check you address and fix the bug? 2. We will be building mobile apps as soon as possible with this functionality.
- Freak_NL 7y agoPlease read up on present day email address validation. If you have a regex that is doing more than ^.+@.+$, then you are doing it wrong. Don't validate the address beyond looking for an '@' in the string; just send an email with a confirmation link to see if it actually works.
- janberchtold 7y agoThanks we will change this!
- dalbotex 7y ago100% this! For reference, I didn't try any of the more obscure email address features, such as comments or quotation. My address simply has the form firstname@lastname.email
- eddyg 7y agoI use: ^[^@]+@[^.]+\..+$ for a bit of sanity checking...
- dalbotex 7y agoMultiple @ symbols are absolutely valid, as long as they are properly quoted ;)
- cvs268 7y ago> just send an email with a confirmation link to see if it actually works. Please don't enable anyone to just send emails to arbitrary email-addresses through you. That's how your email/domain will quickly get marked for SPAM. At the very least, put in place a rate-limit per email-id (and source-ip too maybe). Otherwise i can simply keep entering email-ids of people to spam.
- cvs268 7y agoWhy the -1's ? Isn't this a genuine concern to avoid getting on a SPAM blacklist? What am i missing?...
- shhsshs 7y agoI prefer the true email validation regex: https://regex101.com/r/iE0rF5/1 https://regex101.com/r/iE0rF5/1
- Freak_NL 7y agoI feel bad for the developers who run into that monstrosity and actually implement it.