4 ms·
If you saw the scary permission dialog upgrading, that was due to our mistake: https://twitter.com/reactjs/status/1162174507391574017 https://twitter.com/reactj
by danabramov 7y ago
If you saw the scary permission dialog upgrading, that was due to our mistake: https://twitter.com/reactjs/status/1162174507391574017 https://twitter.com/reactjs/status/1162174507391574017.
Commits with fixes:
* https://github.com/bvaughn/react-devtools-experimental/commit/545de6f02e7d8905ba4e1cd358e68bb640a31a0a https://github.com/bvaughn/react-devtools-experimental/commi...
* https://github.com/bvaughn/react-devtools-experimental/commit/527fc4a63f497db1f370a8312807c2a68147edec https://github.com/bvaughn/react-devtools-experimental/commi...
Both of these issues should be fixed in 4.0.2.
Brian goes into more detail on why we originally added these permissions during the rewrite, and why we were able to remove them: https://www.reddit.com/r/reactjs/comments/cqx554/introducing_the_new_react_devtools/ex0p0m1/ https://www.reddit.com/r/reactjs/comments/cqx554/introducing.... (TLDR: some were for features we ended up cutting; others had easier workarounds that didn't need these permissions.)
The source code is here (https://github.com/bvaughn/react-devtools-experimental/commits/source https://github.com/bvaughn/react-devtools-experimental/commi...). We're currently moving it into React repo so it's easier to find (https://github.com/facebook/react/pull/16381 https://github.com/facebook/react/pull/16381) but haven't managed to make the CI green so the source of truth for releases is still in that branch. We plan to cut over to React repo as source of truth next week.
- ralusek 7y agoYes, thanks for addressing.