2 ms·
It really varies. Someone who infrequently produces perfect 50 line pull requests for unimportant systems won’t require much time spent on code review. Someone
by lacker 7y ago
It really varies. Someone who infrequently produces perfect 50 line pull requests for unimportant systems won’t require much time spent on code review. Someone who frequently produces bug-ridden 1000 line pull requests for mission critical systems requires a ton of time on code review.
The point is not to take a certain amount of time but rather to make sure the code meets your quality standards. Take as much time as this needs.
- arvinsim 7y ago> The point is not to take a certain amount of time but rather to make sure the code meets your quality standards. Take as much time as this needs. This is fine if you have time. But between managing people and doing some tasks yourself, it gets very difficult to give code the proper time to review.
- AndrewDucker 7y agoThen you're taking the risk of allowing through buggy code. That's a risk you have to weigh up against the cost of hiring more developers, or other ways of reducing/spreading the load. There's no magic "I've done enough, so it's not my fault" number someone else can give you.