2 ms·
What are your concerns regarding how much time is spent? On my team all code is reviewed by at least two peers and I find it difficult to not review changes. S
by arenaninja 7y ago
What are your concerns regarding how much time is spent?
On my team all code is reviewed by at least two peers and I find it difficult to not review changes. Sometimes people screw up requirements (or they were unclear and the developer is unfamiliar with the existing implementation), sometimes their variable names suck, or the level of abstraction is inappropriate, or the tests say they're testing one thing but really do another.
On larger code changes this can be up to an hour or two a day (depending on how many are opeened) but I see it as an investment in the health of our codebase and avoiding technical debt.