4 ms·
I've added a few hooks to try to improve code quality over the years. I can't imagine doing that without first running it over the whole repo to make sure it wa
by daveFNbuck 7y ago
I've added a few hooks to try to improve code quality over the years. I can't imagine doing that without first running it over the whole repo to make sure it wasn't flagging good code and cleaning up any legitimate bad code that was caught.
- dharmab 7y agoOur code quality checks run as a CI make target instead of a hook. We then have our repo set up to disallow direct push- everything has to go through a PR and therefore CI.
- daveFNbuck 7y agoEither way, it's important to validate the checks on existing code before making them a blocker.
- dharmab 7y agoYes, which is why I like the make target method. You can make the target apply to new files exclusively at first, then incrementally add old files as they are touched in the course of normal work.