3 ms·

You'll never do that update right? The more you wait, the more that developer will get annoyed when you interrupt them with it. :) In this case actually I woul

by blub 7y ago

You'll never do that update right? The more you wait, the more that developer will get annoyed when you interrupt them with it. :) In this case actually I would have taken the half an hour and sat with them to explain what I think should be done differently and why, prioritized by importance. Reviews done through tools work if there aren't many comments and if the basic design is ok. I've seen reviews where someone's not skilled enough and they have to be taught idioms in dozens of comments in 10-20 patch sets. It's pretty horrible, but the positive side is that at least they're not merging crap.

Stratoscope 7y ago
> You'll never do that update right? I resemble that remark! Yes, procrastinator here. ;-) The thing is, his code is plenty good for now. Even if I never make that update, the code works and people are getting useful results from it. There's nothing overly complicated about it either; I or anyone else could pick it up and easily make any simplifications and improvements whenever needed. And this developer is working on far more important things for the company, mostly in C++. I made the call that it would be better for our business to let him get back to that, since any improvements to the JavaScript code style on this internal tool simply weren't that urgent. But I do appreciate the reminder and I will get to that update soon!