4 ms·
Isn't the point of a pull request to submit code that functionally fixes a bug/adds a small feature, and then work on that patch until it's of sufficient qualit
by cameronbrown 7y ago
Isn't the point of a pull request to submit code that functionally fixes a bug/adds a small feature, and then work on that patch until it's of sufficient quality to merge in? Things like style formatting, running tests among other things could be totally automated away here.
- gwbas1c 7y agoBugfixes and small features need new tests. The tests are often harder, and more time consuming, to write than the bugfix or feature. Edit: And furthermore, when a casual / amateur creates such a pull request, it's not reasonable to expect that person to complete the pull request.