2 ms·
> The technical review wasn't technical. [...] The technical content was entirely found in the comment about ABI compatiblity. That review also had a comment a
by cesarb 7y ago
> The technical review wasn't technical. [...] The technical content was entirely found in the comment about ABI compatiblity.
That review also had a comment about an implicit limit on the number of objects, which is caused by a limit on the amount of physically contiguous memory the kernel memory allocator can obtain at once, and a comment that the code being reviewed would allow for a large increase of the reference count of a couple of important structures. Both appear to be very technical comments to me.
- Sahhaese 7y agoThis is my complaint about the styling issue, that the important technical notes get lost in the 'noise' of styling issues.