3 ms·

Can you share the critique? It would be an interesting read.

• xal 7y ago
  It’s been a long time. If you ever saw the JavaScript “wat” talk, you get the idea. We have since rewritten liquid mostly in C and it has a strict parser mode that’s done with proper approach instead of my hacky regexp based approach.
• trishume 7y ago
  Basically, all the parsing is based on unanchored regexes. This means that Liquid will just ignore syntax that doesn't match what it expects instead of giving a syntax error. One example is `{% if this && that %}`, which is not the correct syntax for logical and but people write in Liquid templates and see that it doesn't give an error so expect it to work, but actually it acts the same as `{% if this %}` and just ignores the invalid suffix.
  • mberning 7y ago
    Thanks!