3 ms·
Just make smaller PRs Sure there's some small overhead to create a PR, but the process proposed here is essentially treating single commits as though they ara
by jacknews 7y ago
Just make smaller PRs
Sure there's some small overhead to create a PR, but the process proposed here is essentially treating single commits as though they ara PRs.
How does that work with CI? I think it's always better to wait until a feature is 'done' and passes tests, before asking others to spend time reviewing it.
A bigger issue is perhaps that a lot of code metadata, ie feature descriptions, design rationales, back-and-forth conversations to hone the code, etc ends up only in the pull request, which is stored on some commercial change-management system, ie github, gitlab, etc, rather than in the intrinsic git history.