4 ms·
Additionally, I think github can do more harm than good here. There is so much code-review you can do before it hits a PR. But then the PR invites nitpicking,
by ljm 7y ago
Additionally, I think github can do more harm than good here.
There is so much code-review you can do before it hits a PR. But then the PR invites nitpicking, over-thinking, and mistaken assumptions. The PR was good when it was submitted but the consensus has all manner of tweaks that are, most of the time, stylistic. Only rarely do you get a serious issue and it gets drowned out in the noise.
This isn’t separating ego from code, it’s accepting that maybe you can do peer review on your code before the fact and any requirement to approve/comment after that must offer something more insightful.