3 ms·
Some people who are less in a hurry want this kind of feedback. (See sibling comment.) So you have to expect some negotiation over what kind of review you want.
by skybrian 7y ago
Some people who are less in a hurry want this kind of feedback. (See sibling comment.) So you have to expect some negotiation over what kind of review you want.
I think the key here is that it should be possible for reviews to mention improvements while not treating them as blocking the commit. When I was reviewing code I would often say this explicitly: "You don't have to do this, but..." Or, I would prefix some comments with "nit: ".
If you're always pushing people to say less in code reviews and they listen, it can turn into a rubber-stamp process. Reviewers need positive feedback too!
- tomlagier 7y agoThis is why I love code review tools with a "task" function (e.g. BitBucket). Adding a task blocks submission until the task is marked completed, but anyone can do that. So, you can approve a CL but add tasks for nits or non-interactive suggestions (things that can be done without needing a response from the reviewer). Then, the author can implement the tasks they find reasonable and ack the rest and not be blocked on submitting by a bunch of back-and-forth over style details.
- allannienhuis 7y agoI use the term ‘consider’ often in code reviews. “Consider using x...” conveys the idea of it being optional but worth their time to think about. I leave ’should’ for things worth arguing about. :)