3 ms·
This is extremely passive. Cool you think that, but do you want them to do anything about it? Maybe "please align the variable definitions."
by rrss 7y ago
This is extremely passive. Cool you think that, but do you want them to do anything about it?
Maybe "please align the variable definitions."
- slavik81 7y agoIt's fine for a review to be passive. The review is about the code, not the person who wrote it. When the reviewer prescribes a solution, it requires the author to push back if they want to solve the issue differently. For example, if they noticed they could delete the variable rather than align it. Though, I'm used to code reviews where the author and reviewer are both professionals and equals. I suppose if the author is an unknown person submitting a patch, you might want to rely less on their professional judgement.
- lhorie 7y agoOr just setup a linter and then you no longer have to babysit whitespace placement