3 ms·
The most annoying thing is when the reviewer doesn't recognise the complexity of some problem, and just insists on doing it in some "simple" way that doesn't so
by Double_a_92 7y ago
The most annoying thing is when the reviewer doesn't recognise the complexity of some problem, and just insists on doing it in some "simple" way that doesn't solve the whole problem.
"Oh you spent 2 weeks figuring this solution out? Well here's my 2 minutes of naïve ideas..."
- Ididntdothis 7y agoThe problem is that the reviewer often doesn’t have time enough time to really understand the problem. So you often end up making trivial comments because you don’t really understand what’s going on.
- lolc 7y agoWhen the reviewer can't understand why the complexity is needed, I add a comment explaining it. This is a very frequent response by me: "Yeah, it's not obvious why the simple approach doesn't work. I've added a comment."
- OJFord 7y agoSometimes I self-review when I can anticipate that, i.e. just leave some (non-code, though it might make me consider that they should be in code) comments with a bit more context. And, of course, commit messages.
- m463 7y agocode reviews are for education, which can go both ways.