3 ms·
Skimming the code I see main.js hasn’t got a single semicolon. If you want to invite others to contribute, you may consider adopting a more widely employed js
by josteink 7y ago
Skimming the code I see main.js hasn’t got a single semicolon.
If you want to invite others to contribute, you may consider adopting a more widely employed js code-style.
This seems to be written in a very personal, opinionated and unconventional way.
- hombre_fatal 7y agoMight as well die on the hill of tabs vs spaces or single-quotes vs double-quotes or trailing commas or space after function name. More useful advice would be: use Prettier and ship a .prettierrc so people can trivially transform their contributions into code consistent with the rest of the project.
- lukey_q 7y agoWriting personal projects in a personal way seems just fine to me :) Looking at that file it's very obvious what's happening after just a cursory glance. I'd much prefer code that's very easy to understand without semicolons than the opposite.
- tom_ 7y agoThat file is a copy of a stock one from the quickstart guide: https://github.com/electron/electron/blob/master/docs/tutorial/first-app.md https://github.com/electron/electron/blob/master/docs/tutori...
- mayeaux 7y agoEven though people have downvoted you, personally I agree with you, I haven't added any semicolons to main.js though because that file was automatically created in the original project I forked, if I ever have to edit it I will add the semicolons as I'm there but I haven't touched that file yet.