3 ms·
> If the abstractions are designed and named well, why should the reviewer need to jump to the declaration of the function in the if statement? How will the re
by falsedan 7y ago
> If the abstractions are designed and named well, why should the reviewer need to jump to the declaration of the function in the if statement?
How will the reviewer know if the abstraction is well-designed or named without reading it? Code quality attitudes change over time so sometimes the standard project-provided helpers end up not matching the intuitions of more recent contributors.
- baddox 7y agoIt’s a valid question, but at some point in a code review you have to trust an abstraction layer, lest you end up reading semiconductor physics papers for every PR.