4 ms·

Using plain makefiles with "gcc" hardcoded in is atrocious, at least use $(CC). This also raises in me the suspicion that it hasn't been tested with no compiler

Using plain makefiles with "gcc" hardcoded in is atrocious, at least use $(CC). This also raises in me the suspicion that it hasn't been tested with no compiler other than GCC at whatever version the developer had installed on his machine, which is bad.

OnlyOneCannolo 7y ago
It's a two line Makefile.
saagarjha 7y ago
I was able to compile this with no issues using "Apple clang version 11.0.0 (clang-1100.0.20.17)". If you're staying within the standard I don't see why you really need to do a whole lot of testing to make sure your project works with other compilers?
foo101 7y ago
Stop! Just stop this! This is a "Show HN" post. Someone out there is trying to develop something useful and share it with the community. By doing so, the author is willingly putting themselves in a vulnerable position where the author's work could be examined critically. The project is also open source. Don't forget that it means that it is being given to you as a gift! If you think this needs more testing, do it yourself. The author of this project does not owe you any testing. If the Makefile works for author, that's good enough for the author. If it isn't good enough for you, fix it. The license allows you to do that. Then consider being nice and giving that fix back to the community with a pull request. Don't come here on your high horse and post vile comments on something that is being shared with you as a gift! If you come here with your pull requests, code, or even better--your own projects, you would be welcome!
kbumsik 7y ago
Really? Do you distribute your project binaries in different versions compiled in various compilers? If not, why is it necessary a bad thing?
max0563 7y ago
Project developer here: Would gladly accept some help with this if you'd be willing to offer it.
- asymptotically2 7y ago
  I just submitted a PR #4 which changes your Makefile to work a little better. Hopefully it makes the parent commenter stop crying too :)
CondensedBrain 7y ago
You can frame a critique in a way that doesn't make the subject feel targeted. Some tips: * Rather than call their way atrocious, try something like "Use $(CC) instead of hard coding gcc to avoid a lot of headaches down the road." * Instead of: >> "This also raises in me the suspicion that it hasn't been tested with no compiler other than GCC at whatever version the developer had installed on his machine, which is bad." Consider: "Test on other machines to make sure you don't depend on quirks of your local gcc installation." Don't tear down. Build up.

OnlyOneCannolo 7y ago

It's a two line Makefile.

saagarjha 7y ago

I was able to compile this with no issues using "Apple clang version 11.0.0 (clang-1100.0.20.17)". If you're staying within the standard I don't see why you really need to do a whole lot of testing to make sure your project works with other compilers?

foo101 7y ago

Stop! Just stop this! This is a "Show HN" post. Someone out there is trying to develop something useful and share it with the community. By doing so, the author is willingly putting themselves in a vulnerable position where the author's work could be examined critically. The project is also open source. Don't forget that it means that it is being given to you as a gift! If you think this needs more testing, do it yourself. The author of this project does not owe you any testing. If the Makefile works for author, that's good enough for the author. If it isn't good enough for you, fix it. The license allows you to do that. Then consider being nice and giving that fix back to the community with a pull request. Don't come here on your high horse and post vile comments on something that is being shared with you as a gift! If you come here with your pull requests, code, or even better--your own projects, you would be welcome!

kbumsik 7y ago

Really? Do you distribute your project binaries in different versions compiled in various compilers? If not, why is it necessary a bad thing?

max0563 7y ago

Project developer here: Would gladly accept some help with this if you'd be willing to offer it.

asymptotically2 7y ago
I just submitted a PR #4 which changes your Makefile to work a little better. Hopefully it makes the parent commenter stop crying too :)

CondensedBrain 7y ago

You can frame a critique in a way that doesn't make the subject feel targeted. Some tips: * Rather than call their way atrocious, try something like "Use $(CC) instead of hard coding gcc to avoid a lot of headaches down the road." * Instead of: >> "This also raises in me the suspicion that it hasn't been tested with no compiler other than GCC at whatever version the developer had installed on his machine, which is bad." Consider: "Test on other machines to make sure you don't depend on quirks of your local gcc installation." Don't tear down. Build up.