3 ms·

I think they're saying he would prefer some semantics - like one is the preferred or normal case, and the other is an error or unexpected case. They might conv

I think they're saying he would prefer some semantics - like one is the preferred or normal case, and the other is an error or unexpected case. They might convey the exact meaning well, but they (and I) would prefer a type with slightly different semantics that better remind us what each side actually represents.

erikpukinskis 7y ago
Did you catch about what OP was saying though? Instead of Normal and Unexpected they are recommending you write something like: const ChargeSuccess = Left const ChargeDeclined = Right And then use that language in your code. Those words tell you something about the semantics of the code being wrapped. “Normal” and “Error” don’t actually mean much. Also, you might want to someday write: const NormalDelivery = Left const FastTrack = Right And that wouldn’t make much sense if fast track is a so-called error condition.
- switchbak 7y ago
  I did see that. This is a common pattern in many functional languages, and (for example) Scala has the same issue with Either. It's a common enough complaint that there are numerous right-biased utility versions in the wild that make it more ergonomic. Having a type that is right biased doesn't mean it can't also implement the more generic interface. If your needs change you can always go back to using the less opinionated version with little breakage. Rust's is notable in that they have both Either and Result. I think there's value in that, even if it is mainly for ergonomics and communication. Also, aliases are fine, I could just see them being duplicated a lot. Probably not my first choice.
  - leshow 7y ago
    > Rust's is notable in that they have both Either and Result. I think there's value in that, even if it is mainly for ergonomics and communication. either isn't in std though, it's a third party crate. Personally, I think the core data structure should be as generic as possible. The reality is that if the Result type was named appropriately, the Either crate would be redundant.
    - ChrisSD 7y ago
      Rust's "generic as possible" type is an enum. Result is a specialization meant for common error handling.
      - leshow 7y ago
        > Rust's "generic as possible" type is an enum What enum? We're talking about a specific data type, it doesn't make any sense to say 'an enum' is the generic version of Result. I understand why they chose Result instead of Either. I just disagree with it; what you end up with is 2 data structures with the exact same structure and implementations but that represent different things. If you have Either in std, then Result is redundant, but not the other way around.
        ChrisSD 7y ago
        What Result? Result is a generic not a specific type. It's essentially a shorthand instead of manually writing out the enum yourself. More fundamentally I disagree that Either makes Result redundant. Result has semantic meaning that's lost with Either.
        leshow 7y ago
        > What Result? Result is a generic not a specific type. It's essentially a shorthand instead of manually writing out the enum yourself. No, it's not 'a generic', but it has generic type parameters. An enum can be any number of variants with any number of type parameters. A result is: data Result a b = Err a | Ok b (or in Rust) enum Result<T, E> { Err(E), Ok(T) } > It's essentially a shorthand instead of manually writing out the enum yourself. I'm not sure which enum you're referring to. You do realise an enum can have any number of variants, not just 2? I could define a sum type with 16 variants. 'enum' is just Rusts keyword for defining sum types. > Result has semantic meaning that's lost with Either. Which is what?
        ChrisSD 7y ago

erikpukinskis 7y ago

Did you catch about what OP was saying though? Instead of Normal and Unexpected they are recommending you write something like: const ChargeSuccess = Left const ChargeDeclined = Right And then use that language in your code. Those words tell you something about the semantics of the code being wrapped. “Normal” and “Error” don’t actually mean much. Also, you might want to someday write: const NormalDelivery = Left const FastTrack = Right And that wouldn’t make much sense if fast track is a so-called error condition.

switchbak 7y ago
I did see that. This is a common pattern in many functional languages, and (for example) Scala has the same issue with Either. It's a common enough complaint that there are numerous right-biased utility versions in the wild that make it more ergonomic. Having a type that is right biased doesn't mean it can't also implement the more generic interface. If your needs change you can always go back to using the less opinionated version with little breakage. Rust's is notable in that they have both Either and Result. I think there's value in that, even if it is mainly for ergonomics and communication. Also, aliases are fine, I could just see them being duplicated a lot. Probably not my first choice.
- leshow 7y ago
  > Rust's is notable in that they have both Either and Result. I think there's value in that, even if it is mainly for ergonomics and communication. either isn't in std though, it's a third party crate. Personally, I think the core data structure should be as generic as possible. The reality is that if the Result type was named appropriately, the Either crate would be redundant.
  - ChrisSD 7y ago
    Rust's "generic as possible" type is an enum. Result is a specialization meant for common error handling.
    - leshow 7y ago
      > Rust's "generic as possible" type is an enum What enum? We're talking about a specific data type, it doesn't make any sense to say 'an enum' is the generic version of Result. I understand why they chose Result instead of Either. I just disagree with it; what you end up with is 2 data structures with the exact same structure and implementations but that represent different things. If you have Either in std, then Result is redundant, but not the other way around.
      - ChrisSD 7y ago
        What Result? Result is a generic not a specific type. It's essentially a shorthand instead of manually writing out the enum yourself. More fundamentally I disagree that Either makes Result redundant. Result has semantic meaning that's lost with Either.
        leshow 7y ago
        > What Result? Result is a generic not a specific type. It's essentially a shorthand instead of manually writing out the enum yourself. No, it's not 'a generic', but it has generic type parameters. An enum can be any number of variants with any number of type parameters. A result is: data Result a b = Err a | Ok b (or in Rust) enum Result<T, E> { Err(E), Ok(T) } > It's essentially a shorthand instead of manually writing out the enum yourself. I'm not sure which enum you're referring to. You do realise an enum can have any number of variants, not just 2? I could define a sum type with 16 variants. 'enum' is just Rusts keyword for defining sum types. > Result has semantic meaning that's lost with Either. Which is what?
        ChrisSD 7y ago