3 ms·
One thing I find interesting, and which I like: As far as I can tell, this commit was merged without the submitter needing to sign a CLA or otherwise assign cop
by CaliforniaKarl 7y ago
One thing I find interesting, and which I like: As far as I can tell, this commit was merged without the submitter needing to sign a CLA or otherwise assign copyright.
- lwf 7y agoThe author signed a CLA. "7 checks passed", and if you click "View Details" you see: > license/cla All CLA requirements met. Also mentioned in https://github.com/microsoft/calculator/blob/master/CONTRIBUTING.md#contributor-license-agreement https://github.com/microsoft/calculator/blob/master/CONTRIBU...
- CaliforniaKarl 7y agoThat's good to know, and annoying, but also a little confusing. The page you linked indicates that a bot will comment on the PR. I am looking at https://github.com/microsoft/calculator/pull/553 https://github.com/microsoft/calculator/pull/553, but I do not see any bot-generated comments, other than the "All CLA requirements met." status line you mentioned; and I do not see a "cla-signed" or a "cla-not-required" tag on the PR. Still annoying, regardless.
- fireattack 7y agoIt says "you only need to do it once for Microsoft projects on GitHub". So maybe the author signed it before.
- MikeHolman 7y agoMicrosoft GitHub projects stopped spamming about CLA a while ago. It will only add a CLA comment to the PR now if you haven't yet signed the CLA and CLA is required. Since this is a one liner, CLA isn't required. But it looks like the CONTRIBUTING.md file wasn't updated to reflect this change.