4 ms·

What this blog post doesn't mention is that they finally addressed the bug where if you have a broken file and looping enabled, it no longer gives you infinite

What this blog post doesn't mention is that they finally addressed the bug where if you have a broken file and looping enabled, it no longer gives you infinite pop-ups saying it can't play the file

saagarjha 7y ago
That’s not a security bug, though?
- Fnoord 7y ago
  But it does belong as bugfix in a 3.0.x version (minor version). Both security and reliability fixes are important.
  - Xylakant 7y ago
    But the blog post is not a release announcement. It’s a discussion of the security fixes and what led to the comparatively high number of security fixes.
DonHopkins 7y ago
I filed a bug report about something just like that many years ago (hanging in a CPU intensive loop if you remove all the files in the looping playlist out form under it, i.e. a disk drive goes offline or USB stick is unplugged), and he brushed it off and dismissed my bug report, telling me simply not to do that. And I also took the time to file several other very detailed bug reports against the Video Effects / Magnification Zoom user interface, which is not only ugly and poorly designed from an ergonomic perspective, but actually drawn into the video at video resolution instead of being drawn in an overlay at full screen resolution, so it gets rotated and is unusable when you combine it with Video Effects / Transform / Rotate, because it fails to transform the mouse events the same as the video and user interface. He brushed that one off as working as designed, too. It's still just the same as it was many years ago when I filed that bug report. I'm serious: Give it a try, you'll fall out of your seat laughing at how terrible it is! Check out the lowres pixelated font it uses to draw "VLC ZOOM HIDE" between the thumbnail and the bizarre curved zoom scale wedge! The mouse target area of the zoom wedge actually diminishes in size with the width of the wedge, until the minimum zoom target area is only one video pixel wide at the bottom, so it's almost impossible to click. (And it's totally impossible to click anywhere when the video is rotated or flipped, since the target area isn't correspondingly transformed.) Yes, I know the drill: It's free software, so I should just download the source code, read it, figure out the problem, fix it myself, and post a pull request. But I don't feel spending my time doing that after the author of VLC won't even admit there's a problem.
- jbk 7y ago
  > and he brushed it off and dismissed my bug report, telling me simply not to do that. I did not do that. That's totally not true. You are confusing me with someone else. And the bug is fixed. > after the author of VLC won't even admit there's a problem. There is no "the author of VLC". There are many persons, and some of them are nicer than others; but spitting on the project for that is not normal. If you have any bugreport that were closed while they should not (transform related), please mail me.
  - DonHopkins 7y ago
    I'll try to dig up the bug report I wrote. Will you at least acknowledge my criticisms of the Video Effects user interface problems, please? Have there ever been any bug reports on that that you can remember? I'll try to dig that one up too. While you're here, I'm really curious: What was the thinking behind the design of the Video Effects / Magnification Zoom interface? Why does it draw into the video instead of using an overlay? Why does the mouse target area of the zoom wedge diminish to be almost impossible to hit? Why doesn't it transform the mouse coordinates for the zoom controls when it rotates the video? Why that font for "VLC ZOOM HIDE"? I understand what "ZOOM" and "HIDE" do, but what is "VLC" for? Just to remind me I'm using VLC?
    - jbk 7y ago
      > Will you at least acknowledge my criticisms of the Video Effects user interface problems, please? Have there ever been any bug reports on that that you can remember? I'll try to dig that one up too. Of course, the video filters UX and UI in VLC is really awful, but very hard to debug for now. > What was the thinking behind the design of the Video Effects / Magnification Zoom interface? It was a very old filter done for the time where you could use remotes through STB and where the filter was streamed. > Why doesn't it transform the mouse coordinates for the zoom controls when it rotates the video? Because rotation was done a long time after, and because rotation is applied at the end, so it can be done on the GPU, while the transform is done before. All that is very buggy, sure. But it requires some core changes that we are doing now 4.0 to improve them quite a bit.
jbk 7y ago
Excellent point: yes, we fixed (actually worked-around) that bug in this release. Sorry about forgetting about it: I cared more about the FOSSA project here, and forgot about this.
- vanderZwan 7y ago
  Oh, don't get me wrong, I'm very grateful! I just wanted to mention it to encourage others to upgrade ;)

What this blog post doesn't mention is that they finally addressed the bug where if you have a broken file and looping enabled, it no longer gives you infinite pop-ups saying it can't play the file

saagarjha 7y ago

That’s not a security bug, though?

Fnoord 7y ago
But it does belong as bugfix in a 3.0.x version (minor version). Both security and reliability fixes are important.
- Xylakant 7y ago
  But the blog post is not a release announcement. It’s a discussion of the security fixes and what led to the comparatively high number of security fixes.

DonHopkins 7y ago

I filed a bug report about something just like that many years ago (hanging in a CPU intensive loop if you remove all the files in the looping playlist out form under it, i.e. a disk drive goes offline or USB stick is unplugged), and he brushed it off and dismissed my bug report, telling me simply not to do that. And I also took the time to file several other very detailed bug reports against the Video Effects / Magnification Zoom user interface, which is not only ugly and poorly designed from an ergonomic perspective, but actually drawn into the video at video resolution instead of being drawn in an overlay at full screen resolution, so it gets rotated and is unusable when you combine it with Video Effects / Transform / Rotate, because it fails to transform the mouse events the same as the video and user interface. He brushed that one off as working as designed, too. It's still just the same as it was many years ago when I filed that bug report. I'm serious: Give it a try, you'll fall out of your seat laughing at how terrible it is! Check out the lowres pixelated font it uses to draw "VLC ZOOM HIDE" between the thumbnail and the bizarre curved zoom scale wedge! The mouse target area of the zoom wedge actually diminishes in size with the width of the wedge, until the minimum zoom target area is only one video pixel wide at the bottom, so it's almost impossible to click. (And it's totally impossible to click anywhere when the video is rotated or flipped, since the target area isn't correspondingly transformed.) Yes, I know the drill: It's free software, so I should just download the source code, read it, figure out the problem, fix it myself, and post a pull request. But I don't feel spending my time doing that after the author of VLC won't even admit there's a problem.

jbk 7y ago
> and he brushed it off and dismissed my bug report, telling me simply not to do that. I did not do that. That's totally not true. You are confusing me with someone else. And the bug is fixed. > after the author of VLC won't even admit there's a problem. There is no "the author of VLC". There are many persons, and some of them are nicer than others; but spitting on the project for that is not normal. If you have any bugreport that were closed while they should not (transform related), please mail me.
- DonHopkins 7y ago
  I'll try to dig up the bug report I wrote. Will you at least acknowledge my criticisms of the Video Effects user interface problems, please? Have there ever been any bug reports on that that you can remember? I'll try to dig that one up too. While you're here, I'm really curious: What was the thinking behind the design of the Video Effects / Magnification Zoom interface? Why does it draw into the video instead of using an overlay? Why does the mouse target area of the zoom wedge diminish to be almost impossible to hit? Why doesn't it transform the mouse coordinates for the zoom controls when it rotates the video? Why that font for "VLC ZOOM HIDE"? I understand what "ZOOM" and "HIDE" do, but what is "VLC" for? Just to remind me I'm using VLC?
  - jbk 7y ago
    > Will you at least acknowledge my criticisms of the Video Effects user interface problems, please? Have there ever been any bug reports on that that you can remember? I'll try to dig that one up too. Of course, the video filters UX and UI in VLC is really awful, but very hard to debug for now. > What was the thinking behind the design of the Video Effects / Magnification Zoom interface? It was a very old filter done for the time where you could use remotes through STB and where the filter was streamed. > Why doesn't it transform the mouse coordinates for the zoom controls when it rotates the video? Because rotation was done a long time after, and because rotation is applied at the end, so it can be done on the GPU, while the transform is done before. All that is very buggy, sure. But it requires some core changes that we are doing now 4.0 to improve them quite a bit.

jbk 7y ago

Excellent point: yes, we fixed (actually worked-around) that bug in this release. Sorry about forgetting about it: I cared more about the FOSSA project here, and forgot about this.

vanderZwan 7y ago
Oh, don't get me wrong, I'm very grateful! I just wanted to mention it to encourage others to upgrade ;)