3 ms·
Code reviews complaining that your code isn't cargo-cult enough.
by lallysingh 7y ago
Code reviews complaining that your code isn't cargo-cult enough.
- zerogvt 7y agoI'll second that. Code reviews -quite often- is a senseless sh_tshow of arrogance, pedantry and psychological issues that have nothing to do with the code.
- lallysingh 7y agoGive people a taste of power and you see their character come out.
- ljm 7y agoI would add 'unforgiving use of linters' to that, where 'unforgiving' generally means that straying even a hair's breadth from the default settings is forbidden. Especially so when you can't adjust those defaults, thus making your post-listed code substantially more abstract and less readable than it would have been at first. Case in point: forcing your simple 11-line function to become something more complicated that has to maintain state through each call.
- silversconfused 7y agoBeen there. Other dev on my team INSISTED on limiting to 80 char lines in a codebase with many long strings. It just wasn't appropriate.