7 ms·
It's funny to see the gradient in the title bar, contrasting with the bland borderless-sea-of-whiteness of the rest of the UI. > FilesUwp.Package_0.5.0.0_x64.z
by userbinator 7y ago
It's funny to see the gradient in the title bar, contrasting with the bland borderless-sea-of-whiteness of the rest of the UI.
> FilesUwp.Package_0.5.0.0_x64.zip 54.4 MB
Nearly 55MB, compressed, for something that attempts to mimic some of the functionality of the regular explorer.exe, is quite frankly ridiculous. I don't have a system to check right now, but I believe even latest Windows 10 has an explorer.exe < 5MB (uncompressed), and it certainly seems to have a lot more functionality than this one. A peek at the code gives a hint as to why... the first file I look at is this
https://github.com/duke7553/files-uwp/blob/master/Files%20UWP/Filesystem/ItemViewModel.cs https://github.com/duke7553/files-uwp/blob/master/Files%20UW...
and the first thing I see is not exactly confidence-inspiring:
if(tabInstance.AlwaysPresentCommands.isEnabled == true)
{
tabInstance.AlwaysPresentCommands.isEnabled = true;
}
else
{
tabInstance.AlwaysPresentCommands.isEnabled = false;
}
...WTF.
It seems that everything "UWP" I come across follows the same trend: a lot of code, a lot of resource consumption, some flashy "modern" UI, yet very little in the way of actual functionality.
- kilpikaarna 7y agoI'd suspect the executable size has more to do with bundled libraries rather than the author having written multiple megabytes worth of if statements...
- kumarharsh 7y agoYou're just talking about 'explorer.exe' being 5 mb? You're discounting the numerous DLLs which the explorer uses, or even other shared resources which are used system-wide. And 55 MB for a native app is paltry. Even the 'Google' app on Android is 285 MB, the Gallery app of OnePlus is 70 MB.
- negativegate 7y agoThe bundle also seems to include dependencies for multiple architectures and PDBs for debugging. Files.dll which would contain most of the application is ~18MB. And since it does not seem to be a managed dll, it has probably been AOT compiled and likely contains the original bytecode in addition to the native machine code.
- userbinator 7y agoYou're discounting the numerous DLLs which the explorer uses, or even other shared resources which are used system-wide. I see this argument brought up in demoscene discussions ("your .exe is 4KB but it uses several GB of system libraries and device drivers!") and the rebuttal is the same: I'm assuming this UWP one itself makes use of other system DLLs too, like any other Windows application will, so the comparison is between 5MB + shared and 55MB + shared. Even the 'Google' app on Android is 285 MB Android is a whole other story altogether. The bloat is endemic there, and emulating that is not at all something to be proud of. Windows applications can be far more efficient, as Windows' own explorer.exe shows (and even that is probably not anywhere close to "perfection", but the difference is already enormous.)
- comex 7y agoIt's not just a matter of using random system functionality; I think Explorer uses the same UI code as Open/Save dialogs, in which case the UI itself necessarily lives in system DLLs. (But I'm a novice when it comes to Windows, so I could be wrong.) That said, the bloat is real.
- poizan42 7y agoYeah, all the file tree view/list view stuff, shell namespace etc. etc. is implemented in shell32.dll, so we should probably compare with explorer.exe + shell32.dll. Everything else are basic widgets and OS interaction which clearly exists in both environments so shouldn't be counted. And with that it is still only 4.27MB+6.81MB = 11.08MB on my system. So yeah, the bloat is real no matter how you look at it.
- ploxiln 7y agoYour standards are unfortunately warped by modern trends. Almost all popular apps are hugely bloated because the developers just don't care, the focus is on UI re-design and feature churn and the illusion of ease of development. Some counter examples (compressed installer size for convenience): 7-zip for 64-bit windows: 1.4 MiB Winamp 5.8: 7.8 MiB mpc-hc: 13.5 MiB (open source media player with many built-in codecs) irfan-view: 3.4 MiB (image viewer/utility) uTorrent: 2.3 MiB Sysinternals Process Monitor: 1 MiB For a truly native application, which doesn't pack a huge run-time or dependency tree, that's the expected size range. Now, it's true, it seems no one does that anymore ...
- kumarharsh 7y agoI agree to those points, and really happy that 7-Zip still fits on a floppy (when the floppy itself is dead). The bloat is real, but it's not something specific to Windows. All three platforms, plus the web, have become bloated. But picking the 50mb size as a stick to beat an app which is still maturing is too harsh, IMO.
- ploxiln 7y agoTrue - and reports seem to be that the actual compiled code is like 18 MiB. It's the comparison to these huge android apps that got me. I could do this for android too: keepassdroid is 4 MiB, zxing barcode scanner is 0.7 MiB ... So many people just don't understand the scale of these things.
- mysterydip 7y agoIf it was just a regular app I'd agree, but file explorer is pretty integral to the OS experience. Any bloat there cascades as multiple instances are launched or called from other applications. As a counterexample, here's XYplorer, another file explorer alternative: https://www.xyplorer.com/ https://www.xyplorer.com/ which weighs in at 7MB.
- 64738 7y agoThank you for mentioning IrfanView. Back in the day I used to have a cracked copy of LviewPro that was always one of the 1st programs to be installed whenever I started working on a new system. It was small, fast, and I could easily flip through all the image files in a directory. I stopped using LviewPro probably 8, or 10 years ago, but always wished I knew of a replacement that was so efficient. I see that IrfanView also does quite a bit more. I think I have a new favorite! Now, if you'll pardon me, I need to drop the author a kind note. :)
- eps 7y ago55 MB is an absolute fuckton. For a native app of Windows Explorer kind that doesn't pack massive resources, 5-10 Megs is a reasonable size. Heck, you are forgetting than something like 3D Studio MAX originially fit on a set of floppies and I can assure you it could do FAR more than "the Gallery app" whatever the heck that poor thing is.
- jcelerier 7y agoon the other hand, just the splash screen image for whatever $modern app can be more than the space available a floppy since you need it normal size, @2x, @3x, it's in 32-bit RGBA instead of 256 color...
- userbinator 7y agoThe fact that it needs a splash screen in the first place is because it takes too long to start because of bloat, so in a way it's a negative feedback cycle.
- jcelerier 7y ago> The fact that it needs a splash screen in the first place is because it takes too long to start because of bloat, so in a way it's a negative feedback cycle. no, had to build a few apps where this was requested only for branding purposes.
- hiperlink 7y agoThis just reminded me of https://prog21.dadgum.com/116.html https://prog21.dadgum.com/116.html Things That Turbo Pascal is Smaller Than
- c-smile 7y agohttp://html-notepad.com http://html-notepad.com - distribution 2,5 Mb (compressed) http://notes.sciter.com http://notes.sciter.com - 2.5 Mb and on all platforms. And these applications are not using "numerous DLLs" - just two files: app.exe and sciter.dll (and that one can be linked statically into executable). So "yes", 50 Mb for an Explorer thing is too much.
- kumarharsh 7y agoAnd there is no gradient on the title bar. That's just the background showing through due to transparency (Acrylic in UWP/Fluent design lingo).
- saagarjha 7y agoDoes Windows not remove translucency when taking screenshots, as macOS does?
- naikrovek 7y agoNo, but sometimes it seems to hide what is behind the translucency so as not to pollute the screenshot. Other times it does not seem to do this. I don't know the pattern or rationale.
- stallmanite 7y agoDumb question: Why is this behavior desired? If I take a screenshot I want an exact record of what is currently displayed. I don’t presume to be a normal user but am super curious about the “other side”. I’ve run into a related behavior on iOS where I really dig some color palette while viewing in inverse colors and want to take a screenshot to capture it. The screenshot is “helpfully” stored as not-inverted color thereby stymying my efforts.
- saagarjha 7y agoIt prevents the generation of consistent screenshots and looks somewhat unprofessional. It's the same reason why product marketing shots don't have clutter on the desktop or a bunch of random applications running in the background.
- jstewartmobile 7y agoMaybe he's just a kid, and we shouldn't shit on him?
- molteanu 7y ago> a lot of code, a lot of resource consumption, some flashy "modern" UI, yet very little in the way of actual functionality. Ah, The Perils of JavaSchools right there. I agree with your comment. That code is beyond horrible, and it keeps on and on. Take a look at the other trending project on HN, Open Source Electronics Lab for $30. It has some nasty surprises on it's own, code-wise.
- saagarjha 7y agoIn all fairness, that code should be trivially optimized: your computer is almost certainly not running that check.
- Sharlin 7y agoHuh? The function is a no-op. The compiler should optimize it into nothingness, but optimization is not the point here. Or was that an attempt at humor?
- saagarjha 7y agoI don't know how much the C# compiler optimizes code, if it does at all, but I do know that the JIT compiler is smart enough to delete this. So I came up with an awkwardly-worded response that provided information that I knew to be true.
- Sharlin 7y agoYes, of course it is trivially optimized out, that's still not the issue. The question is why that function (and several others) exist in the first place! Is there a bug (which is then copypasted several times) and the code is actually supposed to flip between enabled and disabled (in which case it should really be written foo = !foo)? Or something else?
- ac130kz 7y agoI've checked WindowsApps folder once, and there were a ton of apps with an old version (x86, x64, noarch) and a new version (once again all the architectures). In total 6 (!) versions of the same application, each taking up to 60MB. Code quality has dropped significantly as well, Settings, Taskbar, Mail crash and lag.
- Zekio 7y agoActually as far as I can tell, the github app only mimics part of explorer.exe, explorer.exe also is what makes up your taskbar
- koyote 7y agoThe code has many 'smells' indeed but was written by a high schooler. If you take that into account it's really quite commendable how polished and thought-out the app is. Sadly, I have seen 'senior' engineers write much worse code than this...
- dvfjsdhgfv 7y agoIt's because Microsoft heavily promotes the development of UWP apps these days, there are less and less programmers able and willing to spend their time writing Win32 apps, and as you can see even on HN, there are less and less people able to appreciate their effort, even among programmers.
- AnIdiotOnTheNet 7y ago55MB is about as large as the entire Win95 OS install.
- Veen 7y agoI’m curious why it matters to you. 55MB is a trivially inexpensive amount of storage and bandwidth in 2019. It simply doesn’t make a practical difference to the vast majority of people who will use this whether it’s 55MB or 5MB.
- badsectoracula 7y agoIt is a hint that the code sucks.
- 8note 7y agoIs it? I feel like it's a question of prioritizing. Why focus on application size when you could instead polish a feature?
- badsectoracula 7y agoYes it is, if someone doesn't care about creating bloated applications they wont care about creating good applications either - which includes said polishing.
- Veen 7y agoA lack of concern for "bloating" does not entail a lack of concern for user experience. Optimizing for size may be less of a priority when a developer is focused on creating a positive user experience and adding useful features. Obsessive optimization of factors that users don't care about can lead to crappy applications — see quite a few open source GUI applications as an example.
- golf1052 7y agoJust for context I packaged an empty UWP app using the release flag for x64, zipped it, and the final size came out to 23.2 MB.
- rayiner 7y agoThis is unnecessarily negative. I’d imagine all UWP apps are that big, and who knows how much explorer.exe functionality is in DLLs you’re not counting. The author can’t help it if modern frameworks are bloated crap.
- vijaybritto 7y agoStorage is actually pretty cheap. Only RAM usage matters now. So 55mb is not that much of a big deal now. But this is an attempt by the author. No one is forcing you to use this. I dont know whats the point of being so negative to someone's efforts.
- userbinator 7y agoI dont know whats the point of being so negative to someone's efforts. The author is given a very clear indication that this is not a good direction, and hopefully changes direction quickly. He actually replied to another comment I made where I gave some advice (https://news.ycombinator.com/item?id=20130696 https://news.ycombinator.com/item?id=20130696), and said he continued working on it because of "overwhelmingly-positive community feedback", despite already being aware of the limitations of UWP. Maybe if he encountered a bunch of "UWP sucks, go Win32!" comments back then, he might've come up with something far more interesting and useful. In other words, you can blame this idiotic "positivity culture" every time you see something half-assed, bloated, or just plain broken, or when huge mistakes are made because everyone was all smiles and happiness, and no one said NO until it was too late...
- untog 7y agoThe author is a student, so I think we can give them a pass. Besides, the code gets compiled! It's hardly as if that if statement is contributing to bulking out the executable to 55MB. UWP apps tend to be pretty big, especially when compared to Win32/whatever Explorer is written in. That has very little to do with the author and much to do with the framework. It's a little dispiriting to see this as the top HN comment on a high schooler's project .
- kbumsik 7y ago55MB sounds OK to me. At least it is much smaller than typical Electron apps. And the piece of code you show is completely unrelated to your point.
- skinnyarms 7y agoWhy so harsh? This isn't production code published by Microsoft, it's an "enthusiast's take" written by a student learning to code. Most of my college colleagues couldn't make it through FizzBuzz. Hopefully a bright new programmer doesn't get discouraged by getting smacked down in the top comment on hacker news.
- OnlyRepliesToBS 7y agoirrelevant
- kchoudhu 7y agoThank you for your useless driveby code review for a student project on a third party site that could have been an educational pull request to the author.
- bob1029 7y agoI would like to take this opportunity to recommend that everyone who is into C#/.NET Core and high-performance Windows UX development take a look at the following: https://github.com/prasannavl/WinApi https://github.com/prasannavl/WinApi I was able to get a workable demo app going in just a few minutes using their Win32 approach. Seems very promising to me for purposes of building native-levels of performance into windows apps using managed C#. The performance statistics published on the repository seem fantastical, but I can believe it now that I've played around with a few of their demos.