6 ms·
I suspect I'm a minority, but I miss the old days of "download a tgz, make a change, mail the author a patch". There's a lot of effort involved in cloning (the
by tedunangst 16y ago
I suspect I'm a minority, but I miss the old days of "download a tgz, make a change, mail the author a patch". There's a lot of effort involved in cloning (then discovering I need to fork first, then clone my fork), and somehow communicating my change to the author.
I think this has a lot to do with UI. Even after a few attempts at this, I still can't find the various buttons when I want to. For example, there's a pull requests tab on the original repo and on my fork plus another button somewhere above that. Which do I click when?
This is on top of the fact I'm rarely sure if I'm working on the "real" repo or some random dude's copy.
Note I don't dislike DVCS. I like it a lot. But if you don't read the right blogs or wherever it is the cool kids figure out which repos are active and which aren't, the github centric experience is frustrating.
- steveklabnik 16y ago1. Click "fork" 2. Type "git clone git@github.com:mygithubusername/projectname.git" 3. cd projectname 4. make changes, and commit. 5. git push origin master (master may be optional, or a different branch) 6. Click the 'pull request' button 7. Fill out the form 8. You're done! Also, git does support the 'mail the author a patch' workflow, too: it's just not what GitHub uses. I _believe_ the kernel is developed this way. http://www.kernel.org/pub/software/scm/git/docs/git-format-patch.html http://www.kernel.org/pub/software/scm/git/docs/git-format-p... http://stackoverflow.com/questions/327249/ddg http://stackoverflow.com/questions/327249/ddg
- tedunangst 16y ago1. The fork button is a lot smaller than the git clone url staring right up at me in the middle of the page. 6. Which pull request button on which page? There are several. Yes, I've done this a few times. But the procedure is not internalizable in the same way that "mail patch" is. In particular, the pull requests tab always looks really appealing to me whenever I want to clone a new repo (I'd like to make a request to pull your source, after all). The problem is unrelated to git, I could happily use git with email.
- steveklabnik 16y agoYep, I think this is just a preferences thing. The bug "Pull request" tab implies to me that they're pull requests that are currently pending, since it's in amongst the source, the issues... and since it's a tab. The button implies "start a pull request for upstream" since it's up near several other 'action' buttons. To each his own. TMTOWTDI. :)
- sedachv 16y agoYeah, that's twice as many steps as "email the author a patch." But you're right, there's still nothing keeping you from emailing the author a patch (I've contributed to github-hosted projects that way).
- steveklabnik 16y agoThis is mostly first time setup. After you've done it, it becomes "Commit, type git push, click pull request." Same as "Commit, type 'git format-patch', send email."
- technomancy 16y ago> But if you don't read the right blogs or wherever it is the cool kids figure out which repos are active and which aren't, the github centric experience is frustrating. True, Github badly needs a "bless this non-root repository as the canonical one" feature. That's absolutely important for less plugged-in contributors, which may be why it's not as high on their radar.