4 ms·

it's the continuations. you are wrong. it's not a simple fix.

by xlnt 18y ago

cx01 18y ago
The easiest fix would be to get rid of the continuations. It would be just as easy to encode the comment_id in a form field as millions of other webpages do.
- pg 18y ago
  There's more state than that. Read the source and see for yourself.
  - cx01 18y ago
    Ok so I looked at the source and found: (def process-comment (user parent text ip whence)... I don't see why it would be hard to submit "parent" and "text" as POST-parameters. User seems to be stored in a cookie anyway and ip should also be easily retrievable.
aggieben 18y ago
Educate the CPS newbie, here: why do continuations make this difficult?
- Hexstream 18y ago
  Because it's a powerful paradigm used in the wrong place.
- KirinDave 18y ago
  Because multiply invokable continuations have a memory cost associated with them. You need to know when to expire them so that you can reclaim memory. If you didn't do this, every session would take up memory on the system that was never released. That said, the situation could be handled more gracefully by keeping fallback information squirreled away somewhere.
pg 18y ago
It is in fact a simple fix. You just add timeouts. I already did it for the application form. The real answer to the question is: because I have other things to do besides work on cosmetic bug fixes. I'll get to it at some point. In the meantime, please stop submitting "stories" about this. If you discover an important bug, send me an email. Otherwise the place for feature requests and minor bug reports is the feature request page; there is a link to it at the bottom of the front page.
- gizmo 18y ago
  I take it you know that the continuation timeout problem affects replies as well? Because I think it sucks that when I spend more than a few minutes composing a reply I can't post it. On more than one occasion I lost my reply this way. So it's not a cosmetic problem. We're not talking about the minor nuisance of hitting refresh, we're talking about losing carefully crafted replies. Fix it please.
  - pg 18y ago
    If you click on the back button, the text should still be there in the form you submitted. Surely your brower doesn't wipe forms when you click on back?
    - Hexstream 18y ago
      You'd be surprised, that has always been my instinctual reaction to those kinds of failures but oftentimes the textarea would just come back blank for some reason or something like that. I think it had to do with the "you can't go back because the page was generated from a POST operation" kind of message.
    - gizmo 18y ago
      Clicking back is not enough. You also have to refresh the page to get a new continuation. On IE the text is gone after you hit refresh. On firefox the text stays when you hit refresh. Since I'm used to the behavior of firefox... Printing the http-post data on the error page would also help. Because the moment I realize my post is gone I can still hit "forward" to get back to the error message. It's not a perfect solution, but since it only takes 15 seconds to implement it's a fair compromise.
deleted 18y ago
[deleted]

it's the continuations. you are wrong. it's not a simple fix.

by xlnt 18y ago

it's the continuations. you are wrong. it's not a simple fix.

cx01 18y ago

The easiest fix would be to get rid of the continuations. It would be just as easy to encode the comment_id in a form field as millions of other webpages do.

pg 18y ago
There's more state than that. Read the source and see for yourself.
- cx01 18y ago
  Ok so I looked at the source and found: (def process-comment (user parent text ip whence)... I don't see why it would be hard to submit "parent" and "text" as POST-parameters. User seems to be stored in a cookie anyway and ip should also be easily retrievable.

aggieben 18y ago

Educate the CPS newbie, here: why do continuations make this difficult?

Hexstream 18y ago
Because it's a powerful paradigm used in the wrong place.
KirinDave 18y ago
Because multiply invokable continuations have a memory cost associated with them. You need to know when to expire them so that you can reclaim memory. If you didn't do this, every session would take up memory on the system that was never released. That said, the situation could be handled more gracefully by keeping fallback information squirreled away somewhere.

pg 18y ago

It is in fact a simple fix. You just add timeouts. I already did it for the application form. The real answer to the question is: because I have other things to do besides work on cosmetic bug fixes. I'll get to it at some point. In the meantime, please stop submitting "stories" about this. If you discover an important bug, send me an email. Otherwise the place for feature requests and minor bug reports is the feature request page; there is a link to it at the bottom of the front page.

gizmo 18y ago
I take it you know that the continuation timeout problem affects replies as well? Because I think it sucks that when I spend more than a few minutes composing a reply I can't post it. On more than one occasion I lost my reply this way. So it's not a cosmetic problem. We're not talking about the minor nuisance of hitting refresh, we're talking about losing carefully crafted replies. Fix it please.
- pg 18y ago
  If you click on the back button, the text should still be there in the form you submitted. Surely your brower doesn't wipe forms when you click on back?
  - Hexstream 18y ago
    You'd be surprised, that has always been my instinctual reaction to those kinds of failures but oftentimes the textarea would just come back blank for some reason or something like that. I think it had to do with the "you can't go back because the page was generated from a POST operation" kind of message.
  - gizmo 18y ago
    Clicking back is not enough. You also have to refresh the page to get a new continuation. On IE the text is gone after you hit refresh. On firefox the text stays when you hit refresh. Since I'm used to the behavior of firefox... Printing the http-post data on the error page would also help. Because the moment I realize my post is gone I can still hit "forward" to get back to the error message. It's not a perfect solution, but since it only takes 15 seconds to implement it's a fair compromise.

deleted 18y ago

[deleted]